mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 68354: Added a test to verify agent authentication retry backoff logic.
Date Thu, 16 Aug 2018 22:51:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68354/#review207444
-----------------------------------------------------------




src/tests/authentication_tests.cpp
Lines 413 (patched)
<https://reviews.apache.org/r/68354/#comment290848>

    s/Intercept/Drop/
    s/request/attempt/



src/tests/authentication_tests.cpp
Lines 415 (patched)
<https://reviews.apache.org/r/68354/#comment290847>

    Why the underscores?



src/tests/authentication_tests.cpp
Lines 439 (patched)
<https://reviews.apache.org/r/68354/#comment290849>

    s/Intercept/Drop/



src/tests/authentication_tests.cpp
Lines 475-484 (patched)
<https://reviews.apache.org/r/68354/#comment290850>

    Have you considered using an array of expected values? This would also let us loop over
those expected values in a bounded way? E.g.
    
    ```
    slaveFlags.authentication_timeout_min = 5
    slaveFlags.authentication_timeout_max = 60
    slaveFlags.authentication_timeout_factor = 2
    
    expected = [
      [5, 5+2^1]
      [5, 5+2^2]
      ...
      [5, 60]
      [5, 60]
    ]
    
    ```
    
    Seems more readable?


- Benjamin Mahler


On Aug. 16, 2018, 8:55 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68354/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2018, 8:55 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test verifies that the agent backs-off properly when
> retrying authentication according to the configured parameters.
> 
> Also mocked `Slave::authenticate()` for this test.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 802d4eb9e9eba2f1175dd85e56dcc80a61e32f74 
>   src/tests/authentication_tests.cpp 0e8a758ff5061541576317ced079fc59c728f246 
>   src/tests/mock_slave.hpp 9a74bf35d2cab0a72ba6376392239d8080a49304 
>   src/tests/mock_slave.cpp 94a5b0d20475f49dde99108a009682b520175aa4 
> 
> 
> Diff: https://reviews.apache.org/r/68354/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> Added test continuously running without failure.
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message