mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 68347: Added a scheduler flag for max authentication timeout interval.
Date Thu, 16 Aug 2018 19:34:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68347/#review207425
-----------------------------------------------------------


Fix it, then Ship it!





docs/authentication.md
Lines 114 (patched)
<https://reviews.apache.org/r/68347/#comment290811>

    Let's say scheduler driver?
    
    Also, I see you've already called it min here? X-)



src/sched/flags.hpp
Line 124 (original), 124 (patched)
<https://reviews.apache.org/r/68347/#comment290812>

    Probably won't need the minimum emphasis after the rename / deprecated alias change.


- Benjamin Mahler


On Aug. 16, 2018, 12:11 a.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68347/
> -----------------------------------------------------------
> 
> (Updated Aug. 16, 2018, 12:11 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `flags.authentication_timeout_max` controls the
> maximum amount of time the scheduler waits before retrying
> authenticating with the master after a failed attempt.
> 
> Also updated descriptions for related flags
> `flags.authentication_timeout` and
> `flags.authentication_backoff_factor`.
> 
> Also updated documentations regarding configuration and
> authentication.
> 
> 
> Diffs
> -----
> 
>   docs/authentication.md ab3791b7d0c52826213f735b4acf5627b2925330 
>   src/sched/constants.hpp 9edb25b38ba8e7e1dbbb4ce4c957bb6bd9f4af81 
>   src/sched/flags.hpp 2492665d44c424ff9f4f73c796520ebc51abbdff 
>   src/sched/sched.cpp 4de76225c73c9c17904512f5a72303d93ec915a7 
> 
> 
> Diff: https://reviews.apache.org/r/68347/diff/3/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message