mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 68301: WIP: Tests with `default:id`. Not for merging.
Date Thu, 16 Aug 2018 03:13:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68301/
-----------------------------------------------------------

(Updated Aug. 15, 2018, 8:13 p.m.)


Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Joseph Wu.


Repository: mesos


Description (updated)
-------

Need to also add tests for a `taskId` with a `:`.


Diffs (updated)
-----

  src/tests/gc_tests.cpp 4f288cfd70cc53b4064bced96c3c5d6377c1c421 
  src/tests/master_validation_tests.cpp ec4fd13724a44a86ad655fb2a8affbb9f476834f 
  src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8 
  src/tests/slave_tests.cpp 9597067799aaedf9d1c9d797454bb4bdf240cde1 


Diff: https://reviews.apache.org/r/68301/diff/2/

Changes: https://reviews.apache.org/r/68301/diff/1-2/


Testing
-------

This should have _almost_ all the tests pass, except for:

```
[  FAILED  ] 9 tests, listed below:
[  FAILED  ] MesosContainerizer/DefaultExecutorTest.KillTask/0, where GetParam() = "mesos"
[  FAILED  ] MesosContainerizer/DefaultExecutorTest.KillTaskGroupOnTaskFailure/0, where GetParam()
= "mesos"
[  FAILED  ] MesosContainerizer/DefaultExecutorTest.CommitSuicideOnKillTask/0, where GetParam()
= "mesos"
[  FAILED  ] MesosContainerizer/DefaultExecutorTest.MaxCompletionTime/0, where GetParam()
= "mesos"
[  FAILED  ] MesosContainerizer/DefaultExecutorTest.TaskWithFileURI/0, where GetParam() =
"mesos"
[  FAILED  ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.KillTask/0, where
GetParam() = "docker,mesos"
[  FAILED  ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.CommitSuicideOnKillTask/0,
where GetParam() = "docker,mesos"
[  FAILED  ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.MaxCompletionTime/0,
where GetParam() = "docker,mesos"
[  FAILED  ] ROOT_DOCKER_DockerAndMesosContainerizers/DefaultExecutorTest.TaskWithFileURI/0,
where GetParam() = "docker,mesos"
```

Due to long-path issues with `SetCurrentDirectory` that cannot be worked around except via
regedit + manifest.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message