mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.
Date Wed, 15 Aug 2018 21:44:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68324/#review207359
-----------------------------------------------------------


Fix it, then Ship it!





docs/configuration/agent.md
Lines 232-241 (original), 232-266 (patched)
<https://reviews.apache.org/r/68324/#comment290727>

    Can you also update authentication.md?
    
    Be sure to update it with your new changes :)



src/slave/flags.cpp
Lines 356-362 (original), 356-362 (patched)
<https://reviews.apache.org/r/68324/#comment290730>

    The original comment seems more readable to me, and the new one still seems interval oriented
rather than timeout oriented? Here's a suggestion:
    
    ```
    The agent will time out its authentication with the master
    based on exponentional backoff. The timeout will be randomly
    chosen within the range [min, min + factor*2^n] where n is the
    number of failed attempts. To tune these parameters, set the
    `--authentication_timeout_[min|max|factor]` flags. 
    ```



src/slave/flags.cpp
Lines 369 (patched)
<https://reviews.apache.org/r/68324/#comment290729>

    `s/NOTE:/Note that/`



src/slave/slave.cpp
Line 1296 (original), 1296 (patched)
<https://reviews.apache.org/r/68324/#comment290726>

    /+/ +/


- Benjamin Mahler


On Aug. 15, 2018, 6:49 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68324/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2018, 6:49 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
> 
> 
> Bugs: MESOS-9146
>     https://issues.apache.org/jira/browse/MESOS-9146
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> flags.authentication_timeout_min controls the
> minimum amount of time the agent waits before retrying
> authenticating with the master after a failed attempt.
> 
> flags.authentication_timeout_max controls the
> maximum amount of time the agent waits before retrying
> authenticating with the master after a failed attempt.
> 
> 
> Diffs
> -----
> 
>   docs/configuration/agent.md 4e50b681bb956d559da6bf1d2c504099aae3cafb 
>   src/slave/constants.hpp 0bd9f371ca24df66055f31bca0d57625dc7642d9 
>   src/slave/flags.hpp 88c35da5fd754abbd4bd316e1fa9efa4a70a6b8c 
>   src/slave/flags.cpp 54d9acc8693f53294bdc2a88183cac84a8dfbfd9 
>   src/slave/slave.cpp 78e8666f402be58af5b6e20a715da4998af2615c 
>   src/tests/authentication_tests.cpp c9a8f85951a50e278ae509f4efa7105755015ce9 
> 
> 
> Diff: https://reviews.apache.org/r/68324/diff/4/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message