mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 68362: Made RP manager only send resource provider ID on state updates.
Date Wed, 15 Aug 2018 13:53:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68362/
-----------------------------------------------------------

Review request for mesos and Chun-Hung Hsiao.


Bugs: MESOS-8403
    https://issues.apache.org/jira/browse/MESOS-8403


Repository: mesos


Description
-------

With the introduction of the resource provider `SUBSCRIBE` event which
contains the full `ResourceProviderInfo` of a subscribed resource
provider, we can avoid sending the `ResourceProviderInfo` in
`UPDATE_STATE` events and instead only send a `ResourceProviderID`
like in most other messages.


Diffs
-----

  src/resource_provider/manager.cpp abd7e38e5517ea600f9fc9b8a96c7d0d26df0620 
  src/resource_provider/message.hpp 9307f8859035dfafe0952e9026b078b44121537e 
  src/slave/slave.cpp 78e8666f402be58af5b6e20a715da4998af2615c 
  src/tests/resource_provider_manager_tests.cpp 0b9e985cf3b4ded8590615b418e52a2a11f1c1aa 


Diff: https://reviews.apache.org/r/68362/diff/1/


Testing
-------

`make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message