mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Review Request 68360: Removed Principal object from ObjectApprovers class.
Date Wed, 15 Aug 2018 12:04:52 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68360/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

After creation on an `ObjectApprovers` instance, the principal
is only required for providing meaningful log messages.

This commit encodes that at the type system by storing the principal
as a string as opposed to a `Principal` object.


Diffs
-----

  src/common/http.hpp 0901a5528b3c383e3e391a3ac1571fd0fd544998 


Diff: https://reviews.apache.org/r/68360/diff/1/


Testing
-------


Thanks,

Benno Evers


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message