mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 68306: Fixed an authentication request amplification issue in the master.
Date Wed, 15 Aug 2018 06:59:46 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68306/#review207310
-----------------------------------------------------------


Fix it, then Ship it!




Thanks for noticing this! Those callback amplifications are really hard to find. I just added
a couple of nits but feel free to disregard if you disagree with me.


src/master/master.cpp
Line 9601 (original), 9597 (patched)
<https://reviews.apache.org/r/68306/#comment290655>

    I feel this level should be _warning_ instead of _info_. In my opinion if we are in this
situation, something is going wrong somewhere else and the stability of the system is at stake.



src/master/master.cpp
Lines 9627 (patched)
<https://reviews.apache.org/r/68306/#comment290656>

    Same as before, this is probably a warning.


- Alexander Rojas


On Aug. 14, 2018, 12:22 a.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68306/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2018, 12:22 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas, Gastón Kleiman, Meng Zhu, Till Toenshoff,
and Vinod Kone.
> 
> 
> Bugs: MESOS-9144
>     https://issues.apache.org/jira/browse/MESOS-9144
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Per MESOS-9144, re-enqueuing authentication requests leads to an
> amplification effect which can overwhelm the master if requests
> continue to arrive rapidly on a heavily loaded master. This patch
> avoids the re-enqueing and ensures the master immediately processes
> a new authentication request for a client.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 400a83e35451a3ee0ea42b5ca729357bf6c744e8 
> 
> 
> Diff: https://reviews.apache.org/r/68306/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message