mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 68327: Added tests for FUTURE_EXITED and DROP_EXITED.
Date Tue, 14 Aug 2018 23:06:03 GMT


> On Aug. 14, 2018, 10:09 p.m., Gastón Kleiman wrote:
> > 3rdparty/libprocess/src/tests/process_tests.cpp
> > Lines 766-767 (patched)
> > <https://reviews.apache.org/r/68327/diff/1/?file=2072112#file2072112line766>
> >
> >     This might make the test easier to read:
> >     
> >     ```
> >     s/pid/linkedPid/ (or maybe exitingProcessPid? receiver? linkee?)
> >     s/process/linker/
> >     ```
> >     
> >     `ProcessRemoteLinkTest.RemoteDoubleLinkRelink` uses similar names.

This was copy pasted, but I'm all for making it more readable! I'll update these and leave
the existing tests as is for now.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68327/#review207257
-----------------------------------------------------------


On Aug. 13, 2018, 10:22 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68327/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2018, 10:22 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for FUTURE_EXITED and DROP_EXITED.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/process_tests.cpp 17ed2f45c892a3c1c34040a492ad3fdd4a7552c1

> 
> 
> Diff: https://reviews.apache.org/r/68327/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message