mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 68327: Added tests for FUTURE_EXITED and DROP_EXITED.
Date Tue, 14 Aug 2018 22:09:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68327/#review207257
-----------------------------------------------------------




3rdparty/libprocess/src/tests/process_tests.cpp
Lines 762-763 (patched)
<https://reviews.apache.org/r/68327/#comment290589>

    Can we add a description?
    
    Something like:
    
    ```
    Verifies that its possible to intercept `ExitedEvent` events sent to a process upon termination
of another process that it is linked to.
    ``



3rdparty/libprocess/src/tests/process_tests.cpp
Lines 766-767 (patched)
<https://reviews.apache.org/r/68327/#comment290590>

    This might make the test easier to read:
    
    ```
    s/pid/linkedPid/ (or maybe exitingProcessPid? receiver? linkee?)
    s/process/linker/
    ```
    
    `ProcessRemoteLinkTest.RemoteDoubleLinkRelink` uses similar names.



3rdparty/libprocess/src/tests/process_tests.cpp
Lines 776 (patched)
<https://reviews.apache.org/r/68327/#comment290591>

    I'd add an empty line here, to make it consistent with `ProcessTest.Exited` and making
it more obvious that the process being terminated is not the same one that was just spawn.



3rdparty/libprocess/src/tests/process_tests.cpp
Lines 788 (patched)
<https://reviews.apache.org/r/68327/#comment290593>

    Ditto adding a description.



3rdparty/libprocess/src/tests/process_tests.cpp
Lines 800 (patched)
<https://reviews.apache.org/r/68327/#comment290592>

    Ditto empty line.


- Gastón Kleiman


On Aug. 13, 2018, 3:22 p.m., Benjamin Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68327/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2018, 3:22 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Meng Zhu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added tests for FUTURE_EXITED and DROP_EXITED.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/tests/process_tests.cpp 17ed2f45c892a3c1c34040a492ad3fdd4a7552c1

> 
> 
> Diff: https://reviews.apache.org/r/68327/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Mahler
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message