mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 68335: Added a CNI test to verify destroy while preparing.
Date Tue, 14 Aug 2018 08:22:22 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68335/#review207220
-----------------------------------------------------------




src/slave/containerizer/mesos/containerizer.hpp
Lines 196-201 (patched)
<https://reviews.apache.org/r/68335/#comment290515>

    Instead of making this internal method public, can we do something similar with `MesosContainerizerDestroyTest.DestroyWhilePreparing`
which simulates the case of a destroy while isolator preparing is in progress too?



src/tests/containerizer/cni_isolator_tests.cpp
Lines 48-49 (patched)
<https://reviews.apache.org/r/68335/#comment290510>

    A newline between.


- Qian Zhang


On Aug. 14, 2018, 7 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68335/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2018, 7 a.m.)
> 
> 
> Review request for mesos, Deepak Goel, Qian Zhang, and Sergey Urbanovich.
> 
> 
> Bugs: MESOS-9142
>     https://issues.apache.org/jira/browse/MESOS-9142
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This test is used to catch the regression described in MESOS-9142.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp 7711d463c8ed92e2580c56e88d7f372c6dfaeb2b

>   src/tests/containerizer/cni_isolator_tests.cpp cb22e73b4215b5b0a49ac610e5f657b73d38963b

> 
> 
> Diff: https://reviews.apache.org/r/68335/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message