mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 68324: Added two agent flags for min/max authentication retry interval.
Date Tue, 14 Aug 2018 05:37:13 GMT


> On Aug. 13, 2018, 4:14 p.m., Benjamin Mahler wrote:
> > src/slave/flags.cpp
> > Lines 365-380 (patched)
> > <https://reviews.apache.org/r/68324/diff/1/?file=2072099#file2072099line365>
> >
> >     Maybe we should start these with `authentication`? How about:
> >     
> >     ```
> >     authentication_timeout_min
> >     authentication_timeout_max
> >     ```
> >     
> >     I think these will be more easily understood and they're easier to find alongside
other "authentication" prefixed flags?

Done.

I was thinking of being consistent with the seeming convention of putting min/max at the beginning
(see master flags). But I agree that your suggestion can be better understood.


- Meng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68324/#review207178
-----------------------------------------------------------


On Aug. 13, 2018, 10:37 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68324/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2018, 10:37 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
> 
> 
> Bugs: MESOS-9146
>     https://issues.apache.org/jira/browse/MESOS-9146
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `flags.authentication_timeout_min` controls the
> minimum amount of time the agent waits before retrying
> authenticating with the master after a failed attempt.
> 
> `flags.authentication_timeout_max` controls the
> maximum amount of time the agent waits before retrying
> authenticating with the master after a failed attempt.
> 
> 
> Diffs
> -----
> 
>   docs/configuration/agent.md 4e50b681bb956d559da6bf1d2c504099aae3cafb 
>   src/slave/constants.hpp 0bd9f371ca24df66055f31bca0d57625dc7642d9 
>   src/slave/flags.hpp 88c35da5fd754abbd4bd316e1fa9efa4a70a6b8c 
>   src/slave/flags.cpp 54d9acc8693f53294bdc2a88183cac84a8dfbfd9 
>   src/slave/slave.cpp 78e8666f402be58af5b6e20a715da4998af2615c 
>   src/tests/authentication_tests.cpp c9a8f85951a50e278ae509f4efa7105755015ce9 
> 
> 
> Diff: https://reviews.apache.org/r/68324/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message