mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 68054: Added networking statistics to cni isolator.
Date Tue, 14 Aug 2018 00:15:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68054/#review207191
-----------------------------------------------------------



I hit this issue on my box
```
I0813 16:42:29.687569 31007 linux_launcher.cpp:503] Launching container fae92a9a-561f-40a5-b49e-896be36fcf8b
and cloning with namespaces CLONE_NEWNS | CLONE_NEWUTS | CLONE_NEWNET
I0813 16:42:29.700687 31005 containerizer.cpp:3021] Transitioning the state of container fae92a9a-561f-40a5-b49e-896be36fcf8b
from PREPARING to ISOLATING
I0813 16:42:29.702626 30978 cni.cpp:954] Bind mounted '/proc/31055/ns/net' to '/run/mesos/isolators/network/cni/fae92a9a-561f-40a5-b49e-896be36fcf8b/ns'
for container fae92a9a-561f-40a5-b49e-896be36fcf8b
I0813 16:42:29.899713 30981 cni.cpp:1385] Got assigned IPv4 address '203.0.113.2/24' from
CNI network 'veth' for container fae92a9a-561f-40a5-b49e-896be36fcf8b
I0813 16:42:29.900835 30982 cni.cpp:1094] Unable to find DNS nameservers for container fae92a9a-561f-40a5-b49e-896be36fcf8b,
using host '/etc/resolv.conf'
I0813 16:42:30.102488 30996 containerizer.cpp:3021] Transitioning the state of container fae92a9a-561f-40a5-b49e-896be36fcf8b
from ISOLATING to FETCHING
I0813 16:42:30.105840 30992 containerizer.cpp:3021] Transitioning the state of container fae92a9a-561f-40a5-b49e-896be36fcf8b
from FETCHING to RUNNING
Marked '/' as rslave
I0813 16:42:30.236037 31088 exec.cpp:162] Version: 1.7.0
W0813 16:42:31.245690 31126 process.cpp:1449] Failed to link to '10.0.49.2:44965', connect:
Failed to connect to 10.0.49.2:44965: No route to host
I0813 16:42:31.246233 31106 exec.cpp:527] Agent exited ... shutting down
I0813 16:42:31.246580 31106 v0_v1executor.cpp:172] Implicitly connecting the executor to shut
it down
I0813 16:42:31.247351 31110 executor.cpp:182] Received SHUTDOWN event
I0813 16:42:31.248729 31110 executor.cpp:796] Shutting down
I0813 16:42:31.250615 31126 process.cpp:926] Stopped the socket accept loop
I0813 16:42:31.308015 30980 containerizer.cpp:2860] Container fae92a9a-561f-40a5-b49e-896be36fcf8b
has exited
I0813 16:42:31.308157 30980 containerizer.cpp:2407] Destroying container fae92a9a-561f-40a5-b49e-896be36fcf8b
in RUNNING state
I0813 16:42:31.308187 30980 containerizer.cpp:3021] Transitioning the state of container fae92a9a-561f-40a5-b49e-896be36fcf8b
from RUNNING to DESTROYING
I0813 16:42:31.309753 31017 linux_launcher.cpp:582] Asked to destroy container fae92a9a-561f-40a5-b49e-896be36fcf8b
I0813 16:42:31.311748 31017 linux_launcher.cpp:629] Destroying cgroup '/sys/fs/cgroup/freezer/mesos/fae92a9a-561f-40a5-b49e-896be36fcf8b'
```


src/slave/containerizer/mesos/isolators/network/cni/cni.hpp
Lines 191 (patched)
<https://reviews.apache.org/r/68054/#comment290484>

    nits: kill this line.



src/tests/containerizer/cni_isolator_tests.cpp
Lines 2256 (patched)
<https://reviews.apache.org/r/68054/#comment290488>

    I would like to add the cleanup code to `CniIsolatorTest::cleanup`.
    
    It's possible that the test is ended with sigkill or ctrl+c. And `ip link add name vethmesostest0
type veth peer name vethmesostestns` might fail if the veth hasn't been cleaned up


- Jie Yu


On Aug. 10, 2018, 7:08 p.m., Sergey Urbanovich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68054/
> -----------------------------------------------------------
> 
> (Updated Aug. 10, 2018, 7:08 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Qian Zhang.
> 
> 
> Bugs: MESOS-5647
>     https://issues.apache.org/jira/browse/MESOS-5647
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> On receiving a request for getting `usage` for a given container
> the `network/cni` isolator uses getifaddrs(3) glibc function. The
> function returns basic networking metrics for each networking
> interface in the container networking namespace. It should work
> right out of the box on all modern Linux-based systems.
> 
> To get more networking metrics please use Netlink Protocol Library.
> However, you will have to open NETLINK sockets in each networking
> namespace and manage them from the `network/cni` isolator.
> 
> JIRA: https://issues.apache.org/jira/browse/MESOS-5647
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.hpp 31ec4ddb1049b7259b0784e5e40b002e29f6a8da

>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp f46c962d8f044092aaa113fafc536c6b25bab45c

>   src/slave/flags.hpp eeb9708f9ec76d83b6719541f4a012544c7c0cbe 
>   src/slave/flags.cpp 58cdc0f1100fe244e5bf1036e1ccf39478d5d478 
>   src/tests/containerizer/cni_isolator_tests.cpp cae2c1950c6e5218f7fc7cebd93f5b4ed687fb5a

> 
> 
> Diff: https://reviews.apache.org/r/68054/diff/5/
> 
> 
> Testing
> -------
> 
> bin/mesos-tests.sh --verbose --gtest_filter="CniIsolatorTest.ROOT_VerifyResourceStatistics"
--gtest_break_on_failure --gtest_repeat=100
> 
> 
> Thanks,
> 
> Sergey Urbanovich
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message