mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 68222: Added 2 tests for `docker/volume` isolator to cover read-only volume.
Date Mon, 13 Aug 2018 23:48:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68222/#review207193
-----------------------------------------------------------




src/tests/containerizer/docker_volume_isolator_tests.cpp
Lines 1175-1179 (patched)
<https://reviews.apache.org/r/68222/#comment290485>

    why do we have 1 here?



src/tests/containerizer/docker_volume_isolator_tests.cpp
Lines 1307-1311 (patched)
<https://reviews.apache.org/r/68222/#comment290486>

    ditto.


- Gilbert Song


On Aug. 7, 2018, 7:24 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68222/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2018, 7:24 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8814
>     https://issues.apache.org/jira/browse/MESOS-8814
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added 2 tests for `docker/volume` isolator to cover read-only volume.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/docker_volume_isolator_tests.cpp c15a6fad642474765e4ad1952af6cd9ee937379e

> 
> 
> Diff: https://reviews.apache.org/r/68222/diff/2/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message