mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 68304: Fixed a bug in the agent authentication retry logic.
Date Mon, 13 Aug 2018 23:06:16 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68304/#review207172
-----------------------------------------------------------



Just a quick review since you're updating the logic.

How about:

```
Fixed a backoff overflow bug in agent authentication retry logic.
```

A little more in the commit description to clarify the old vs new approach would be nice for
posterity (e.g. why did we decide to combine them?)


src/slave/slave.cpp
Lines 1375-1376 (patched)
<https://reviews.apache.org/r/68304/#comment290467>

    Can you move this to `AUTHENTICATION_RETRY_INTERVAL_MIN` in the `slave/constants.hpp`
and put the TODO to consider the flag there?


- Benjamin Mahler


On Aug. 13, 2018, 9:53 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68304/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2018, 9:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Gastón Kleiman.
> 
> 
> Bugs: MESOS-9147
>     https://issues.apache.org/jira/browse/MESOS-9147
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch fixed the backoff time calculation
> overflow bug described in MESOS-9147.
> 
> This patch also combines the authentication timeout and
> authentication retry backoff interval into a single
> wait time interval.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 802d4eb9e9eba2f1175dd85e56dcc80a61e32f74 
>   src/slave/slave.cpp 78e8666f402be58af5b6e20a715da4998af2615c 
>   src/tests/authentication_tests.cpp c9a8f85951a50e278ae509f4efa7105755015ce9 
> 
> 
> Diff: https://reviews.apache.org/r/68304/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message