mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 68331: Windows: Made `libwinio` the default option.
Date Mon, 13 Aug 2018 22:35:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68331/
-----------------------------------------------------------

Review request for mesos, Akash Gupta, Benjamin Mahler, and Joseph Wu.


Bugs: MESOS-9084
    https://issues.apache.org/jira/browse/MESOS-9084


Repository: mesos


Description
-------

With no options specified, Windows will now build with the
`libwinio` (native Windows Thread API eventing library) by
default (similar to POSIX defaulting to `libev` without options). To
use `libevent` (NOT recommended), it must be explicitly enabled, and
will emit an appropriate warning. Furthermore, the tests which were
previously excluded when `libevent` was enabled are now enabled on
Windows unconditionally. This serves two reasons: (1) it simplifies
the build logic and (2) by failing with `libevent` it demonstrates why
it is not recommended (and avoids giving false impressions).


Diffs
-----

  3rdparty/CMakeLists.txt 629b1968775da4d128b8d36c77d75efa303b0b7c 
  cmake/CompilationConfigure.cmake 10cacfb99e2cff1ddd2285ae441730f61182e06d 
  docs/windows.md f0f12fc81ed664528cf7496cf75e1cb11eee6013 
  src/tests/CMakeLists.txt fed072a8a761c6b9e65b2c75f2e92facd8353f7c 


Diff: https://reviews.apache.org/r/68331/diff/1/


Testing
-------

Built with and without `-DENABLE_LIBEVENT` on Windows.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message