mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 68214: Updated `volume/sandbox_path` isolator to honor volume mode.
Date Mon, 13 Aug 2018 04:15:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68214/#review207135
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp
Line 373 (original), 373 (patched)
<https://reviews.apache.org/r/68214/#comment290359>

    Not yours, but could we remove this?


- Gilbert Song


On Aug. 7, 2018, 7:18 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68214/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2018, 7:18 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8814
>     https://issues.apache.org/jira/browse/MESOS-8814
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated `volume/sandbox_path` isolator to honor volume mode.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 4896c6811c2c59dcf00871b7a8b6b9b50da0f062

> 
> 
> Diff: https://reviews.apache.org/r/68214/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message