mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benno Evers <bev...@mesosphere.com>
Subject Re: Review Request 68224: Augmented `Statistics` to work with any collection.
Date Thu, 09 Aug 2018 14:38:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68224/#review207037
-----------------------------------------------------------


Fix it, then Ship it!





3rdparty/libprocess/include/process/statistics.hpp
Lines 75 (patched)
<https://reviews.apache.org/r/68224/#comment290199>

    Let's verify that iterators can be re-used after computing the distance:
    
    ```
    static_assert(!std::is_same<
        typename std::iterator_traits<It>::iterator_category,
        std::input_iterator_tag>::value)
    ```
    
    (Or even add another `enable_if` to the signature, if you prefer)


- Benno Evers


On Aug. 9, 2018, 2:20 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68224/
> -----------------------------------------------------------
> 
> (Updated Aug. 9, 2018, 2:20 p.m.)
> 
> 
> Review request for mesos, Benno Evers and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/statistics.hpp e9f1fc23bf83f92a2e7de94dba0df48272cc3394

>   3rdparty/libprocess/src/tests/statistics_tests.cpp a2a780bf9de018c823b68aa48977fd9fd1b8a064

> 
> 
> Diff: https://reviews.apache.org/r/68224/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message