mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rukletsov <ruklet...@gmail.com>
Subject Re: Review Request 68131: Added MasterPooledStateQuery_BENCHMARK_Test.
Date Thu, 09 Aug 2018 13:58:57 GMT


> On Aug. 6, 2018, 11:40 a.m., Benno Evers wrote:
> > src/tests/master_benchmarks.cpp
> > Lines 628 (patched)
> > <https://reviews.apache.org/r/68131/diff/2/?file=2068403#file2068403line628>
> >
> >     The `async()` seems unnecessary here, we can just call the function directly.

This is true. However, it does not hurt and _looks_ more consistent, hence I'd leave it unless
you have a strong opinion.


> On Aug. 6, 2018, 11:40 a.m., Benno Evers wrote:
> > src/tests/master_benchmarks.cpp
> > Lines 634 (patched)
> > <https://reviews.apache.org/r/68131/diff/2/?file=2068403#file2068403line634>
> >
> >     Maybe we should add one run here where we query only `stateEndpoint` without
hitting `indicatorEndpoint` at the same time?

I don't think we should. The aim of the test is to measure the responsiveness of the master
actor and not the performance of the '/state' endpoint.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68131/#review206877
-----------------------------------------------------------


On Aug. 6, 2018, 10:30 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68131/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2018, 10:30 a.m.)
> 
> 
> Review request for mesos, Benno Evers and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8975
>     https://issues.apache.org/jira/browse/MESOS-8975
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/tests/master_benchmarks.cpp b6d6dc7c1752491e2da854018966374b624d6682 
> 
> 
> Diff: https://reviews.apache.org/r/68131/diff/2/
> 
> 
> Testing
> -------
> 
> See https://reviews.apache.org/r/68132/
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message