mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 68262: Removed unused operator overloads in `Resources`.
Date Tue, 07 Aug 2018 22:35:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68262/#review206959
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On Aug. 7, 2018, 7:45 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68262/
> -----------------------------------------------------------
> 
> (Updated Aug. 7, 2018, 7:45 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> `Resources::operator+(Resource_)` (and minus counterparts) are
> currently not used. This patch removes these overloads.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 6d81d0e25827db5a165a211ccbea804047db7989 
>   include/mesos/v1/resources.hpp f34f38fe25b295306210587f8de8372ebf4ca8e2 
>   src/common/resources.cpp cef2acd565911fc59e751c3135675515b2e22c59 
>   src/v1/resources.cpp aa775bd361752bd890a0474eca613b2bccfc5275 
> 
> 
> Diff: https://reviews.apache.org/r/68262/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message