mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Review Request 68263: Fixed Windows build break due to missing lambda capture.
Date Tue, 07 Aug 2018 20:40:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68263/
-----------------------------------------------------------

Review request for mesos and James Peach.


Repository: mesos


Description
-------

Since no default capture semantics were specified, `messageCount` was
not captured which MSVC refused to compile. Interestingly, clang emits
a warning if `messageCount` is captured explicitly, so we compromise
with an implicit value capture and explicit reference capture of `q`.


Diffs
-----

  3rdparty/libprocess/src/tests/benchmarks.cpp 16b3bca44ca3e9a5fddd93fa02b9a3021c696fda 


Diff: https://reviews.apache.org/r/68263/diff/1/


Testing
-------

Windows build, cquery (clang) did not emit warning.


Thanks,

Andrew Schwartzmeyer


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message