mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chun-Hung Hsiao <chhs...@apache.org>
Subject Review Request 68251: Pass compiler/linker flags when building the gRPC bundle in libprocess.
Date Tue, 07 Aug 2018 02:40:28 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68251/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and James Peach.


Bugs: MESOS-9137
    https://issues.apache.org/jira/browse/MESOS-9137


Repository: mesos


Description
-------

Since gRPC does not use Autotools, we have to manually pass compiler and
linker flags when issuing `make` to make the build flags consistent with
the Mesos build that initiate the gRPC bundle build.

With this fix, libprocess can be configured as follows to enable the
thread sanitizer:
  CFLAGS='-fsanitize=thread'
  CXXFLAGS='-fsanitize=thread'
  LDFLAGS='-fsanitize=thread'

Also, we now only compile `libglog.la`, as we do in Mesos builds, to
avoid the following GLOG compilation issue when enabling the thread
sanitizer: https://github.com/google/glog/issues/54


Diffs
-----

  3rdparty/libprocess/3rdparty/Makefile.am 55414190fd8fb8f9f2d220701ed7531b99b95797 


Diff: https://reviews.apache.org/r/68251/diff/1/


Testing
-------

`make check` for standalone libprocess build.


Thanks,

Chun-Hung Hsiao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message