mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 68242: Added tests for `Resources` move semantics.
Date Tue, 07 Aug 2018 02:29:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68242/#review206923
-----------------------------------------------------------


Ship it!





src/tests/resources_tests.cpp
Lines 1081-1083 (original), 1122-1124 (patched)
<https://reviews.apache.org/r/68242/#comment290069>

    A comment here to clarify why we're wrapping in a Resources()?
    
    This should probably be Resource() non-plural to cover that case?



src/tests/resources_tests.cpp
Line 1251 (original), 1310 (patched)
<https://reviews.apache.org/r/68242/#comment290074>

    Ditto above, comments on these would be helpful to the reader:
    
    ```
     r += Resources(ports2); // Test +=(Resources&&).
    ```



src/tests/resources_tests.cpp
Lines 2114 (patched)
<https://reviews.apache.org/r/68242/#comment290073>

    Newline above the comment here and below



src/tests/resources_tests.cpp
Line 3538 (original), 3655 (patched)
<https://reviews.apache.org/r/68242/#comment290070>

    comment here about why the temporary is used?


- Benjamin Mahler


On Aug. 6, 2018, 11:30 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68242/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2018, 11:30 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9110
>     https://issues.apache.org/jira/browse/MESOS-9110
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary
> 
> 
> Diffs
> -----
> 
>   src/tests/resources_tests.cpp 9475b6ea014434b8d9c7a5c1ba793cd78b10536b 
> 
> 
> Diff: https://reviews.apache.org/r/68242/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message