mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 67502: Refactored ReviewBoard API functionality into separate module.
Date Mon, 06 Aug 2018 20:49:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67502/#review206908
-----------------------------------------------------------




support/python3/common.py
Lines 146 (patched)
<https://reviews.apache.org/r/67502/#comment290034>

    Pylint complains that there are too many local variables, you can remove `latest_diff_url`
to have only 15 vars in the file.


- Armand Grillet


On July 19, 2018, 3:48 p.m., Dragos Schebesch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67502/
> -----------------------------------------------------------
> 
> (Updated July 19, 2018, 3:48 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Refactored API functionality into separate module -- this was done to clean up the codebase
and put all API calls in single place.
> 
> 
> Diffs
> -----
> 
>   support/python3/common.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67502/diff/4/
> 
> 
> Testing
> -------
> 
> For example, to call the api on a specific review_url, with some data, we would use the
following code:
> 
> ```
> ReviewBoardHandler().api(review_url, data)
> ```
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message