mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 68095: Modified MesosContainerizer to GC nested container sandboxes.
Date Mon, 06 Aug 2018 20:44:38 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68095/#review206906
-----------------------------------------------------------



Issues spotted while doing some manual testing:


src/slave/containerizer/mesos/containerizer.hpp
Lines 54-59 (original), 54-59 (patched)
<https://reviews.apache.org/r/68095/#comment290031>

    It may be necessary to suppress certain log messages in the GC actor.  Health checks launched
via nested containers will also have their sandboxes scheduled for GC, which results in at
least one log message per directory.
    
    We could also consider avoiding scheduling health check nested containers for GC.



src/slave/containerizer/mesos/containerizer.cpp
Lines 2769-2770 (original), 2829-2830 (patched)
<https://reviews.apache.org/r/68095/#comment290032>

    Need to unschedule directories for GC when they are removed.  It's possible that ContainerIDs
will be reused after removal, and if we don't unschedule, a reused ContainerID/sandbox could
be GC'd while it is in use.


- Joseph Wu


On July 27, 2018, 5:22 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68095/
> -----------------------------------------------------------
> 
> (Updated July 27, 2018, 5:22 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Qian Zhang.
> 
> 
> Bugs: MESOS-7947
>     https://issues.apache.org/jira/browse/MESOS-7947
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> When the --gc_non_executor_container_sandboxes agent flag is enabled,
> this commit changes the MesosContainerizer to schedule nested container
> sandboxes for garbage collection.  The GC policy is the same between
> the MesosContainerizer and the Agent.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp 7711d463c8ed92e2580c56e88d7f372c6dfaeb2b

>   src/slave/containerizer/mesos/containerizer.cpp 98129d006cda9b65804b518619b6addc8990410a

> 
> 
> Diff: https://reviews.apache.org/r/68095/diff/1/
> 
> 
> Testing
> -------
> 
> See last patch in chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message