mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 67503: Added support helper for fetching review ids.
Date Mon, 06 Aug 2018 20:36:31 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67503/#review206382
-----------------------------------------------------------


Fix it, then Ship it!




LGTM except the first line. FYI the commit header and message should contain no line that
are more than 72 characters.


support/python3/get-review-ids.py
Lines 1 (patched)
<https://reviews.apache.org/r/67503/#comment290026>

    Should be `python3`.


- Armand Grillet


On July 19, 2018, 3:48 p.m., Dragos Schebesch wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67503/
> -----------------------------------------------------------
> 
> (Updated July 19, 2018, 3:48 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Armand Grillet.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added helper for fetching review id, which is needed to decouple this logic from verify-reviews.py.
We need this for the windows build so we can trigger a downstream job for each review request
on another server.
> 
> 
> Diffs
> -----
> 
>   support/python3/get-review-ids.py PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67503/diff/4/
> 
> 
> Testing
> -------
> 
> Sample run on this review request id:
> ```
> ./get-review-ids.py -r 67503
> Dependent review: https://reviews.apache.org/api/review-requests/67502/
> 67502
> 
> 67503
> ```
> 
> 
> Thanks,
> 
> Dragos Schebesch
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message