mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrei Budnik <abud...@mesosphere.com>
Subject Re: Review Request 68016: Added libseccomp to the build.
Date Mon, 06 Aug 2018 16:19:58 GMT


> On July 31, 2018, 12:33 a.m., Andrew Schwartzmeyer wrote:
> > cmake/CompilationConfigure.cmake
> > Lines 538-541 (patched)
> > <https://reviews.apache.org/r/68016/diff/1/?file=2062779#file2062779line538>
> >
> >     What targets need `ENABLE_SECCOMP_ISOLATOR` defined? Presumably this is new
code, so we don't have to leave this as a to-do. (And I'm guessing just `libmesos PRIVATE`?)

Yeah, `ENABLE_SECCOMP_ISOLATOR` is used only by `libmesos`.
What is the best way to pass `-DENABLE_SECCOMP_ISOLATOR` compiler flag into `libmesos` build,
but omit it for `3rdparty`?


- Andrei


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68016/#review206629
-----------------------------------------------------------


On Aug. 6, 2018, 1:38 p.m., Andrei Budnik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68016/
> -----------------------------------------------------------
> 
> (Updated Aug. 6, 2018, 1:38 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Gilbert Song, Jie Yu, James Peach, and
Qian Zhang.
> 
> 
> Bugs: MESOS-9032
>     https://issues.apache.org/jira/browse/MESOS-9032
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This library is needed to implement Seccomp syscall filtering in the
> Mesos containerizer. This patch introduces `seccomp-isolator` build
> flag, which is used to include or exclude sources related to Seccomp
> from the build. Since Seccomp is a Linux-specific feature, the flag
> is disabled by default. Enabling `seccomp-isolator` means either:
> 
> 1. Compiling and linking against the bundled version of libseccomp from
>    sources (default).
> 
> 2. Linking against the libseccomp installed in the OS,
>    if `--with-libseccomp` build flag is provided.
> 
> 
> Diffs
> -----
> 
>   3rdparty/CMakeLists.txt 629b1968775da4d128b8d36c77d75efa303b0b7c 
>   3rdparty/Makefile.am 6476b043090b24e8a70982a887b21096752b5581 
>   3rdparty/cmake/Versions.cmake c65d7b3d2d48ce9d0b4777aeb12fdf5b605803ac 
>   3rdparty/versions.am 8fd8bd4d7482af5304ab0b56270e49f447e0b3f5 
>   cmake/CompilationConfigure.cmake 10cacfb99e2cff1ddd2285ae441730f61182e06d 
>   configure.ac d84581823708cdece68d52bdc023e01d72645bf8 
>   src/CMakeLists.txt a80b011bbd5c418ae66eb8dd7697d070168462bb 
>   src/Makefile.am cf0cf22b3f582d3d4427f13288af3845aef45263 
> 
> 
> Diff: https://reviews.apache.org/r/68016/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Andrei Budnik
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message