mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Armand Grillet <agril...@mesosphere.io>
Subject Re: Review Request 67185: Added request_protobuf to mesos.http.
Date Mon, 06 Aug 2018 14:52:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67185/#review206793
-----------------------------------------------------------



LGTM, I suggest merging this after the Python 3 update of mesos.http.


src/python/lib/mesos/http.py
Lines 31 (patched)
<https://reviews.apache.org/r/67185/#comment290005>

    Please insert one new line before.



src/python/lib/mesos/http.py
Lines 41 (patched)
<https://reviews.apache.org/r/67185/#comment290004>

    The `mesos.constants` imports should be before the `mesos.exception` ones alphabetically.



src/python/lib/mesos/http.py
Lines 196 (patched)
<https://reviews.apache.org/r/67185/#comment290006>

    Why is it not `PROTOBUF_ENCODING` instead of `self.default_encoding` as we know that we
want to encode a protobuf message?



src/python/lib/mesos/http.py
Lines 345 (patched)
<https://reviews.apache.org/r/67185/#comment290007>

    Should these match the parameter names from `request()`?


- Armand Grillet


On June 28, 2018, 6:17 a.m., Eric Chung wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67185/
> -----------------------------------------------------------
> 
> (Updated June 28, 2018, 6:17 a.m.)
> 
> 
> Review request for mesos, Armand Grillet, Jason Lai, Kevin Klues, and Zhitao Li.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change adds the method `Resource.request_protobuf()` which assumes
> that both the request and response data are encoded in protobuf. This
> will be used later in the RPC client, which will also include a decoding
> step.
> 
> Testing Done:
> Ran unit tests with `tox` under `src/python/lib`
> 
> 
> Diffs
> -----
> 
>   src/python/lib/mesos/constants.py PRE-CREATION 
>   src/python/lib/mesos/http.py 073c159dc6916fa5d7349a033db022d7175aef05 
>   src/python/lib/requirements.in 0742f3d846c99c1c4907d9628fb49845564563b2 
>   src/python/lib/tests/test_http.py 66dd6d7c6272d1828dd591829ca3543d3430f69b 
> 
> 
> Diff: https://reviews.apache.org/r/67185/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Eric Chung
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message