mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Qian Zhang <zhq527...@gmail.com>
Subject Re: Review Request 68203: Updated volume isolators to honor volume mode.
Date Mon, 06 Aug 2018 07:29:50 GMT


> On Aug. 5, 2018, 1:46 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/volume/host_path.cpp
> > Lines 318 (patched)
> > <https://reviews.apache.org/r/68203/diff/2/?file=2067547#file2067547line319>
> >
> >     I'd suggest we separate this patch, and have one patch for each isolator (we
might want to backport a few, like host path volume).
> >     
> >     Also, add unit test for each isolator.
> 
> Jie Yu wrote:
>     NVM, i saw the subsequent tests. Let's separate this patch please. we might want
to backport a few to old releases

Agree.


- Qian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68203/#review206864
-----------------------------------------------------------


On Aug. 4, 2018, 5:58 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68203/
> -----------------------------------------------------------
> 
> (Updated Aug. 4, 2018, 5:58 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8814
>     https://issues.apache.org/jira/browse/MESOS-8814
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated volume isolators to honor volume mode.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 76f1a5243c8d5028157f795d851b547a5ce57ac9

>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp ab749be6234a5eedc0617a131c126129f43f8d62

>   src/slave/containerizer/mesos/isolators/volume/host_path.cpp 9127cf4a9d8aa2b16bb5b9903103f1f76a1e2b1a

>   src/slave/containerizer/mesos/isolators/volume/image.hpp 706b8ff28e1b1c8d15606d54d40622bc09885667

>   src/slave/containerizer/mesos/isolators/volume/image.cpp 345772439b73b4816f71e15bb4e43a5d67c51c02

>   src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp 4896c6811c2c59dcf00871b7a8b6b9b50da0f062

>   src/slave/containerizer/mesos/isolators/volume/secret.cpp 663aafc7173667f8f78b26bdc824a3ab2e04ed25

> 
> 
> Diff: https://reviews.apache.org/r/68203/diff/2/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message