mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] jieyu opened a new pull request #306: Fixed the iptables deadlock in CNI port mapper plugin.
Date Sun, 05 Aug 2018 05:36:08 GMT
jieyu opened a new pull request #306: Fixed the iptables deadlock in CNI port mapper plugin.
URL: https://github.com/apache/mesos/pull/306
 
 
   Patch 1: 
   
   It is possible that the port mapping cleanup command will cause iptables
   to deadlock if there are a lot of entires in the iptables, because the
   `sed` won't process the next line while executing 'iptables -w -t nat -D
   ...'. But the executing of 'iptables -w -t nat -D ...' might get stuck
   if the first command 'iptables -w -t nat -S %s' didn't finish (because
   the xtables lock is not released). The first command might not finish if
   it has a lot of output, filling the pipe that `sed` hasn't had a chance
   to process yet. See more details in MESOS-9127.
   
   This patch fixed the issue by writing the commands to a file and then
   executing them.
   
   Patch 2:
   
   Updated port mapper CNI test.
   
   This patch updated the port mapper CNI test to launch multiple
   containers concurrently. This would allow us to catch the scenarios
   where multiple iptables commands are executed concurrently.
   
   This test fails if the fix for MESOS-9125 is not included.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

Mime
View raw message