mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 67788: Added regression test for archiver utility symlink extraction.
Date Fri, 29 Jun 2018 23:55:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67788/#review205598
-----------------------------------------------------------


Ship it!




Ship It!

- Andrew Schwartzmeyer


On June 29, 2018, 11:44 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67788/
> -----------------------------------------------------------
> 
> (Updated June 29, 2018, 11:44 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Kapil Arya.
> 
> 
> Bugs: MESOS-9038
>     https://issues.apache.org/jira/browse/MESOS-9038
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This modifies an existing test to account for archives with symlinks
> under subdirectories.
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/tests/archiver_tests.cpp cdf24a5d9accb1082e8bf3809c865a92d93e63d8 
> 
> 
> Diff: https://reviews.apache.org/r/67788/diff/1/
> 
> 
> Testing
> -------
> 
> ```
> make check
> 
> # Revert the commit that fixed MESOS-9038.
> git revert 22471b83a418e614b19a7ae50b73ee028dc7c363 --no-edit
> cmake --build . --target stout-tests
> 
> # Now this is expected to fail.
> 3rdparty/stout/tests/stout-tests --gtest_filter="*SYMLINK_ExtractTarGzFileWithLinks*"
> ```
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message