mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 67762: Added minimum capability check during master recovery.
Date Fri, 29 Jun 2018 23:37:04 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67762/
-----------------------------------------------------------

(Updated June 29, 2018, 4:37 p.m.)


Review request for mesos, Benjamin Mahler and Joseph Wu.


Changes
-------

Thanks for the review! Patch updated.


Bugs: MESOS-8880
    https://issues.apache.org/jira/browse/MESOS-8880


Repository: mesos


Description
-------

Added minimum capability check during master registry
recovery to guard against incompatible downgrade.
See MESOS-8878.

Also added a dedicated test.


Diffs (updated)
-----

  include/mesos/mesos.proto 463e6adcdf14115b2f21270bb1fd9c45e1b67cc3 
  include/mesos/v1/mesos.proto 8eaad9c4b2a9cdd527922a004b0f7dd0dc58a7f1 
  src/master/master.hpp 2ce71dca52245b41533728a7564c65daa135b224 
  src/master/master.cpp ddc8df0ea82241be6c733237feef1553c7669eb2 
  src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb 


Diff: https://reviews.apache.org/r/67762/diff/3/

Changes: https://reviews.apache.org/r/67762/diff/2-3/


Testing
-------

make check


Thanks,

Meng Zhu


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message