mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joseph Wu <jos...@mesosphere.io>
Subject Re: Review Request 67762: Added minimum capability check during master recovery.
Date Fri, 29 Jun 2018 21:33:34 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67762/#review205583
-----------------------------------------------------------




src/master/master.hpp
Lines 443-444 (patched)
<https://reviews.apache.org/r/67762/#comment288459>

    You could simplify the return type to `vector<string>`, as the empty `vector` is
basically the same as returning `None`.



src/master/master.cpp
Lines 399-403 (patched)
<https://reviews.apache.org/r/67762/#comment288457>

    Is there any particular reason why you've wrapped this logic inside a lambda?  You'd get
roughly the same result if you unwrapped the logic.



src/master/master.cpp
Lines 406-418 (patched)
<https://reviews.apache.org/r/67762/#comment288460>

    Consider defining a `hash<MasterInfo::Capability::Type>` and performing a hashset
subtraction instead of these loops.


- Joseph Wu


On June 27, 2018, 10:01 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67762/
> -----------------------------------------------------------
> 
> (Updated June 27, 2018, 10:01 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Joseph Wu.
> 
> 
> Bugs: MESOS-8880
>     https://issues.apache.org/jira/browse/MESOS-8880
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added minimum capability check during master registry
> recovery to guard against incompatible downgrade.
> See MESOS-8878.
> 
> Also added a dedicated test.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 463e6adcdf14115b2f21270bb1fd9c45e1b67cc3 
>   include/mesos/v1/mesos.proto 8eaad9c4b2a9cdd527922a004b0f7dd0dc58a7f1 
>   src/master/master.hpp 4180341e2c7b16503a4376c501f611bb78ba901c 
>   src/master/master.cpp 4ade16f044f8a4fdafd5afaba4e6a23232f83a5a 
>   src/tests/master_tests.cpp 8e04023ed04e79881e0d323c2e2283bebaf262eb 
> 
> 
> Diff: https://reviews.apache.org/r/67762/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message