mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 67780: Removed incorrect symlink handling in archiver utility.
Date Fri, 29 Jun 2018 04:20:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67780/#review205557
-----------------------------------------------------------



PASS: Mesos patch 67780 was successfully built and tested.

Reviews applied: `['67780']`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67780

- Mesos Reviewbot Windows


On June 29, 2018, 9 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67780/
> -----------------------------------------------------------
> 
> (Updated June 29, 2018, 9 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer and Kapil Arya.
> 
> 
> Bugs: MESOS-9038
>     https://issues.apache.org/jira/browse/MESOS-9038
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> While fixing MESOS-9008, we accidentally assumed that all links needed
> to be corrected when extracting to a different directory.  This is
> necessary for hardlinks because a hardlink must point to a file
> extracted earlier in the archive.  However, for symlinks, this is not
> the case.  When extracted with no header modifications, symlinks will
> point to their intended target (i.e. relative symlinks will not be
> transformed into targetting absolute paths).
> 
> 
> Diffs
> -----
> 
>   3rdparty/stout/include/stout/archiver.hpp 0f249296182172f9b01d53a5f86403689df5a9fa

> 
> 
> Diff: https://reviews.apache.org/r/67780/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> Manually tested this change against the archive here:
> https://downloads.mesosphere.com/libmesos-bundle/libmesos-bundle-1.11.0.tar.gz
> 
> ^ Specifically looking at items symlinked under `libmesos-bundle/lib/mesos`.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message