mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 67779: WIP: Introduced `CREATE_DISK` and `DESTROY_DISK` operations.
Date Fri, 29 Jun 2018 01:32:00 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67779/#review205546
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67779']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67779

Relevant logs:

- [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67779/logs/mesos-tests-cmake-stdout.log):

```
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301):
warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj]
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368):
warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj]
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372):
warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj]
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512):
warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj]
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543):
warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s
instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(548):
warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead.
To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj]
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
         d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(569):
warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s
instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details.
[D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]


       "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\src\java\mesos-java.vcxproj" (default target) (15) ->
       (ClCompile target) -> 
         d:\dcos\mesos\mesos\src\master\validation.hpp(315): error C2039: 'CreateVolume':
is not a member of 'mesos::Offer_Operation' (compiling source file D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_v1_scheduler_V0Mesos.cpp)
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         d:\dcos\mesos\mesos\src\master\validation.hpp(315): error C4430: missing type specifier
- int assumed. Note: C++ does not support default-int (compiling source file D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_v1_scheduler_V0Mesos.cpp)
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         d:\dcos\mesos\mesos\src\master\validation.hpp(315): error C2143: syntax error: missing
',' before '&' (compiling source file D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_v1_scheduler_V0Mesos.cpp)
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         d:\dcos\mesos\mesos\src\master\validation.hpp(316): error C2039: 'DestroyVolume':
is not a member of 'mesos::Offer_Operation' (compiling source file D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_v1_scheduler_V0Mesos.cpp)
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         d:\dcos\mesos\mesos\src\master\validation.hpp(316): error C4430: missing type specifier
- int assumed. Note: C++ does not support default-int (compiling source file D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_v1_scheduler_V0Mesos.cpp)
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         d:\dcos\mesos\mesos\src\master\validation.hpp(316): error C2143: syntax error: missing
',' before '&' (compiling source file D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_v1_scheduler_V0Mesos.cpp)
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         d:\dcos\mesos\mesos\src\master\validation.hpp(317): error C2039: 'CreateBlock': is
not a member of 'mesos::Offer_Operation' (compiling source file D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_v1_scheduler_V0Mesos.cpp)
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         d:\dcos\mesos\mesos\src\master\validation.hpp(317): error C4430: missing type specifier
- int assumed. Note: C++ does not support default-int (compiling source file D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_v1_scheduler_V0Mesos.cpp)
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         d:\dcos\mesos\mesos\src\master\validation.hpp(317): error C2143: syntax error: missing
',' before '&' (compiling source file D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_v1_scheduler_V0Mesos.cpp)
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         d:\dcos\mesos\mesos\src\master\validation.hpp(318): error C2039: 'DestroyBlock':
is not a member of 'mesos::Offer_Operation' (compiling source file D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_v1_scheduler_V0Mesos.cpp)
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         d:\dcos\mesos\mesos\src\master\validation.hpp(318): error C4430: missing type specifier
- int assumed. Note: C++ does not support default-int (compiling source file D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_v1_scheduler_V0Mesos.cpp)
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]
         d:\dcos\mesos\mesos\src\master\validation.hpp(318): error C2143: syntax error: missing
',' before '&' (compiling source file D:\DCOS\mesos\mesos\src\java\jni\org_apache_mesos_v1_scheduler_V0Mesos.cpp)
[D:\DCOS\mesos\src\java\mesos-java.vcxproj]

    172 Warning(s)
    12 Error(s)

Time Elapsed 00:06:33.10
```

- Mesos Reviewbot Windows


On June 29, 2018, 12:40 a.m., Chun-Hung Hsiao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67779/
> -----------------------------------------------------------
> 
> (Updated June 29, 2018, 12:40 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Gastón Kleiman, Greg Mann, James DeFelice,
and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch introduces `CREATE_DISK` and `DESTROY_DISK` operations for
> conversion between RAW disk resaurces and MOUNT/BLOCK disk resources to
> replace `CREATE_VOLUME`/`DESTROY_VOLUME`/`CREATE_BLOCK`/`DESTROY_BLOCK`.
> 
> This replacement involves two aspects:
> 
> 1. Renaming: The term "volume" is overloaded and created name conflicts
>    in mesos. This renaming would lead to cleaner names in ACL and other
>    places, and is more consistent with CSI.
> 
> 2. Removing PATH support. PATH disks are used to split a disk resource
>    into smaller chunks for concurrent independent uses. However, this
>    concept does not quite fit CSI well.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 463e6adcdf14115b2f21270bb1fd9c45e1b67cc3 
>   include/mesos/v1/mesos.proto 8eaad9c4b2a9cdd527922a004b0f7dd0dc58a7f1 
> 
> 
> Diff: https://reviews.apache.org/r/67779/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message