mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gastón Kleiman <gas...@mesosphere.io>
Subject Re: Review Request 67776: Added per Framework Calls to metrics.
Date Fri, 29 Jun 2018 01:01:05 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67776/#review205544
-----------------------------------------------------------




src/master/metrics.cpp
Lines 566 (patched)
<https://reviews.apache.org/r/67776/#comment288437>

    Nice!



src/master/metrics.cpp
Lines 595 (patched)
<https://reviews.apache.org/r/67776/#comment288438>

    Should we add a CHECK here making sure that `call_types` contains `callType`?


- Gastón Kleiman


On June 28, 2018, 3:41 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67776/
> -----------------------------------------------------------
> 
> (Updated June 28, 2018, 3:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Gastón Kleiman, and Gilbert Song.
> 
> 
> Bugs: MESOS-8843
>     https://issues.apache.org/jira/browse/MESOS-8843
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch adds master metrics which count all scheduler call types,
> for each framework which registers with the master.
> 
> 
> Diffs
> -----
> 
>   src/master/http.cpp 0492b979e4657a489ca3428e6f8022ef20cb05f5 
>   src/master/master.cpp 4ade16f044f8a4fdafd5afaba4e6a23232f83a5a 
>   src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b 
>   src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 
> 
> 
> Diff: https://reviews.apache.org/r/67776/diff/1/
> 
> 
> Testing
> -------
> 
> Testing details can be found at the end of this chain.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message