mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Meng Zhu <m...@mesosphere.io>
Subject Re: Review Request 67444: Persisted role consumed quota info in the allocator.
Date Thu, 28 Jun 2018 23:33:39 GMT


> On June 28, 2018, 3:25 p.m., Mesos Reviewbot Windows wrote:
> > FAIL: Some of the unit tests failed. Please check the relevant logs.
> > 
> > Reviews applied: `['67773', '67444']`
> > 
> > Failed command: `Start-MesosCITesting`
> > 
> > All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67444
> > 
> > Relevant logs:
> > 
> > - [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67444/logs/mesos-tests-stdout.log):
> > 
> > ```
> > [       OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (127 ms)
> > [----------] 9 tests from Endpoint/SlaveEndpointTest (1029 ms total)
> > 
> > [----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
> > [ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
> > [       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (38 ms)
> > [ RUN      ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
> > [       OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (38 ms)
> > [----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (77 ms total)
> > 
> > [----------] 1 test from IsolationFlag/CpuIsolatorTest
> > [ RUN      ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
> > [       OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (848 ms)
> > [----------] 1 test from IsolationFlag/CpuIsolatorTest (870 ms total)
> > 
> > [----------] 1 test from IsolationFlag/MemoryIsolatorTest
> > [ RUN      ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
> > [       OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (838 ms)
> > [----------] 1 test from IsolationFlag/MemoryIsolatorTest (859 ms total)
> > 
> > [----------] Global test environment tear-down
> > [==========] 990 tests from 98 test cases ran. (460605 ms total)
> > [  PASSED  ] 989 tests.
> > [  FAILED  ] 1 test, listed below:
> > [  FAILED  ] MesosContainerizer/DefaultExecutorTest.SigkillExecutor/0, where GetParam()
= "mesos"
> > 
> >  1 FAILED TEST
> >   YOU HAVE 220 DISABLED TESTS
> > 
> > ```
> > 
> > - [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67444/logs/mesos-tests-stderr.log):
> > 
> > ```
> > I0628 22:25:13.862025 19180 master.cpp:10900] Updating the state of task c4b533f8-2e56-4c92-bcfe-6d053a2640a7
of framework 831789c0-9734-4768-8415-c26da2d176e3-0000 (latest state: TASK_KILLED, status
update state: TASK_KILLED)
> > I0628 22:25:13.862025 20224 slave.cpp:3939] Shutting down framework 831789c0-9734-4768-8415-c26da2d176e3-0000
> > I0628 22:25:13.862025 20224 slave.cpp:6660] Shutting down executor 'c4b533f8-2e56-4c92-bcfe-6d053a2640a7'
of framework 831789c0-9734-4768-8415-c26da2d176e3-0000 at executor(1)@192.10.1.6:59686
> > I0628 22:25:13.864045 20224 slave.cpp:931] Agent terminating
> > W0628 22:25:13.I0628 22:25:13.658028 18908 exec.cpp:162] Version: 1.7.0
> > I0628 22:25:13.683043 20960 exec.cpp:236] Executor registered on agent 831789c0-9734-4768-8415-c26da2d176e3-S0
> > I0628 22:25:13.687032 15960 executor.cpp:182] Received SUBSCRIBED event
> > I0628 22:25:13.691023 15960 executor.cpp:186] Subscribed executor on windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net
> > I0628 22:25:13.691023 15960 executor.cpp:182] Received LAUNCH event
> > I0628 22:25:13.696027 15960 executor.cpp:679] Starting task c4b533f8-2e56-4c92-bcfe-6d053a2640a7
> > I0628 22:25:13.777024 15960 executor.cpp:499] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe
launch <POSSIBLY-SENSITIVE-DATA>'
> > I0628 22:25:13.833027 15960 executor.cpp:693] Forked command at 20420
> > I0628 22:25:13.864045 18700 exec.cpp:445] Executor asked to shutdown
> > I0628 22:25:13.865029 15960 executor.cpp:182] Received SHUTDOWN event
> > I0628 22:25:13.865029 15960 executor.cpp:796] Shutting down
> > I0628 22:25:13.865029 15960 executor.cpp:909] Sending SIGTERM to process tree at
pid 20864045 20224 slave.cpp:3935] Ignoring shutdown framework 831789c0-9734-4768-8415-c26da2d176e3-0000
because it is terminating
> > I0628 22:25:13.864045 19180 master.cpp:10999] Removing task c4b533f8-2e56-4c92-bcfe-6d053a2640a7
with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated:
*):[31000-32000] of framework 831789c0-9734-4768-8415-c26da2d176e3-0000 on agent 831789c0-9734-4768-8415-c26da2d176e3-S0
at slave(449)@192.10.1.6:59665 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
> > I0628 22:25:13.868031 19180 master.cpp:1330] Agent 831789c0-9734-4768-8415-c26da2d176e3-S0
at slave(449)@192.10.1.6:59665 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
disconnected
> > I0628 22:25:13.868031 19180 master.cpp:3340] Disconnecting agent 831789c0-9734-4768-8415-c26da2d176e3-S0
at slave(449)@192.10.1.6:59665 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
> > I0628 22:25:13.868031 19180 master.cpp:3359] Deactivating agent 831789c0-9734-4768-8415-c26da2d176e3-S0
at slave(449)@192.10.1.6:59665 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net)
> > I0628 22:25:13.869029 17956 hierarchical.cpp:346] Removed framework 831789c0-9734-4768-8415-c26da2d176e3-0000
> > I0628 22:25:13.869029  2308 containerizer.cpp:2407] Destroying container 6a2ae4d4-7c1d-4cb9-974a-bf416a9b8690
in RUNNING state
> > I0628 22:25:13.869029 17956 hierarchical.cpp:769] Agent 831789c0-9734-4768-8415-c26da2d176e3-S0
deactivated
> > I0628 22:25:13.869029  2308 containerizer.cpp:3021] Transitioning the state of container
6a2ae4d4-7c1d-4cb9-974a-bf416a9b8690 from RUNNING to DESTROYING
> > I0628 22:25:13.870044  2308 launcher.cpp:155] Asked to destroy container 6a2ae4d4-7c1d-4cb9-974a-bf416a9b8690
> > I0628 22:25:13.957221 20916 containerizer.cpp:2860] Container 6a2ae4d4-7c1d-4cb9-974a-bf416a9b8690
has exited
> > I0628 22:25:13.984226 21420 master.cpp:1172] Master terminating
> > I0628 22:25:13.986282 20224 hierarchical.cpp:612] Removed agent 831789c0-9734-4768-8415-c26da2d176e3-S0
> > I0628 22:25:14.324815 13620 process.cpp:940] Stopped the socket accept loop
> > ```

This is a flaky test. Filed https://issues.apache.org/jira/browse/MESOS-9037 and posted fix
https://reviews.apache.org/r/67778/


- Meng


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67444/#review205537
-----------------------------------------------------------


On June 28, 2018, 1:55 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67444/
> -----------------------------------------------------------
> 
> (Updated June 28, 2018, 1:55 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8802
>     https://issues.apache.org/jira/browse/MESOS-8802
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The allocator needs to keep track of role consumed quota
> to maintain quota headroom. Currently this info is
> constructed on the fly prior to each allocation cycle.
> 
> This patch lets the allocator buildup and persist this info
> across allocation cycles to improve performance and reduce
> code complexity.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 0f6c0e96a105c64465d3f5db4ff663d8fdfe7e26

>   src/master/allocator/mesos/hierarchical.cpp cbdfb2ba9c25755ac631557e0e7dbd721f861a4d

> 
> 
> Diff: https://reviews.apache.org/r/67444/diff/1/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message