mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot <revi...@mesos.apache.org>
Subject Re: Review Request 67767: Removed the isolators ordering check from `gpu/nvidia` isolator.
Date Thu, 28 Jun 2018 09:32:27 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67767/#review205496
-----------------------------------------------------------



Patch looks great!

Reviews applied: [67767]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose
--disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 28, 2018, 7:14 a.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67767/
> -----------------------------------------------------------
> 
> (Updated June 28, 2018, 7:14 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and James Peach.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We do not need to check the isolators ordering because we have made
> the order of built-in isolators fixed in MESOS-7643.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/gpu/isolator.cpp 50668828a9167a2a190922a534c37b145cbfb784

> 
> 
> Diff: https://reviews.apache.org/r/67767/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message