mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Mahler <bmah...@apache.org>
Subject Re: Review Request 67590: Added a dedicated benchmark for range resources.
Date Thu, 28 Jun 2018 01:29:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67590/#review205488
-----------------------------------------------------------



Great to see this!

Can you update the testing done to say whether this was measured with an optimized build?
If not, can you add the optimized build measurements?


src/tests/resources_tests.cpp
Lines 3944 (patched)
<https://reviews.apache.org/r/67590/#comment288401>

    The default port ranges in mesos is 31000-32000, and a user could set it to something
like 10000-32000, so we probably also want to test in the tens of thousands worst case.
    
    E.g. 100, 1000, 10000



src/tests/resources_tests.cpp
Lines 3947 (patched)
<https://reviews.apache.org/r/67590/#comment288400>

    After figuring out what ranges are used, it looks like we probably want to specialize
this name? E.g. ArithmeticOverlapping



src/tests/resources_tests.cpp
Lines 3949-3970 (patched)
<https://reviews.apache.org/r/67590/#comment288398>

    It's hard to understand what this is doing, can you describe what ports 1 and 2 look like
or what the idea is here? Am I reading right?
    
    ports1 = [1-6, 11-16, 21-26, ...]
    ports2 = [3-8, 13-18, 23-28, ...]
    
    It looks like there's a lot of overlap in the ranges? It's probably worth describing why
we do this (is it trying to match total-allocated?). We probably also want to name the test
with "overlap" to clarify the relationship between port ranges in this test (vs say, ranges
with no overlap).



src/tests/resources_tests.cpp
Lines 3954-3959 (patched)
<https://reviews.apache.org/r/67590/#comment288399>

    Looks like this can be:
    
    ```
    ports1 += createPorts(createRange(port1Index, port1Index + stride);
    ```
    
    https://github.com/apache/mesos/blob/1.6.0/src/tests/resources_utils.hpp#L45-L62



src/tests/resources_tests.cpp
Lines 3978 (patched)
<https://reviews.apache.org/r/67590/#comment288402>

    This measurement is also including the copy of ports1 into result, shouldn't we exclude
that? Ditto for -=


- Benjamin Mahler


On June 13, 2018, 11:28 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67590/
> -----------------------------------------------------------
> 
> (Updated June 13, 2018, 11:28 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-8989
>     https://issues.apache.org/jira/browse/MESOS-8989
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> Also removed the current range benchmark which could produce
> misleading results for subtraction (See MESOS-8989).
> 
> 
> Diffs
> -----
> 
>   src/tests/resources_tests.cpp 2da583615ac8a8fb238f4996fe661343b718bad1 
> 
> 
> Diff: https://reviews.apache.org/r/67590/diff/1/
> 
> 
> Testing
> -------
> 
> Ran on a multicore machine with peak frequency at 2.2GHz:
> 
> Took 25.435531ms to perform 1000 'a += b' operations on ports:[1-6, 11-16, 21-26... and
ports:[3-8, 13-18, 23-28... with size 10
> Took 76.104895ms to perform 1000 'a -= b' operations on ports:[1-6, 11-16, 21-26... and
ports:[3-8, 13-18, 23-28... with size 10
> Took 28.66989ms to perform 1000 'a + b' operations on ports:[1-6, 11-16, 21-26... and
ports:[3-8, 13-18, 23-28... with size 10
> Took 79.937531ms to perform 1000 'a - b' operations on ports:[1-6, 11-16, 21-26... and
ports:[3-8, 13-18, 23-28... with size 10
> 
> Took 360.16389ms to perform 1000 'a += b' operations on ports:[1-6, 11-16, 21-26... and
ports:[3-8, 13-18, 23-28... with size 100
> Took 812.057397ms to perform 1000 'a -= b' operations on ports:[1-6, 11-16, 21-26...
and ports:[3-8, 13-18, 23-28... with size 100
> Took 298.568732ms to perform 1000 'a + b' operations on ports:[1-6, 11-16, 21-26... and
ports:[3-8, 13-18, 23-28... with size 100
> Took 799.168596ms to perform 1000 'a - b' operations on ports:[1-6, 11-16, 21-26... and
ports:[3-8, 13-18, 23-28... with size 100
> 
> Took 5.499557097secs to perform 1000 'a += b' operations on ports:[1-6, 11-16, 21-26...
and ports:[3-8, 13-18, 23-28... with size 1000
> Took 10.80984876secs to perform 1000 'a -= b' operations on ports:[1-6, 11-16, 21-26...
and ports:[3-8, 13-18, 23-28... with size 1000
> Took 5.105380254secs to perform 1000 'a + b' operations on ports:[1-6, 11-16, 21-26...
and ports:[3-8, 13-18, 23-28... with size 1000
> Took 11.025490666secs to perform 1000 'a - b' operations on ports:[1-6, 11-16, 21-26...
and ports:[3-8, 13-18, 23-28... with size 1000
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message