mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 67751: WIP: Added missing files to CMake build.
Date Tue, 26 Jun 2018 23:20:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67751/#review205403
-----------------------------------------------------------




src/Makefile.am
Lines 2711-2718 (original), 2711-2718 (patched)
<https://reviews.apache.org/r/67751/#comment288291>

    This was backwards from where it was first declared.


- Andrew Schwartzmeyer


On June 26, 2018, 4:12 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67751/
> -----------------------------------------------------------
> 
> (Updated June 26, 2018, 4:12 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James Peach, and Joseph Wu.
> 
> 
> Bugs: MESOS-8994
>     https://issues.apache.org/jira/browse/MESOS-8994
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> WIP: Added missing files to CMake build.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5 
>   src/Makefile.am bd94a6488c1c1cc2481b9e9edb25307ced8c0d21 
>   src/cli/CMakeLists.txt 7b2abf2fe14888ec1da11414189f71da972ac427 
>   src/python/executor/CMakeLists.txt PRE-CREATION 
>   src/python/scheduler/CMakeLists.txt PRE-CREATION 
>   src/slave/containerizer/mesos/CMakeLists.txt ba1f92fe7dd59c34c6dee0bc7ecf6f1b5160eee8

>   src/tests/CMakeLists.txt b9c906d7e91e8e2ce3ec76f972169f9b592a6132 
> 
> 
> Diff: https://reviews.apache.org/r/67751/diff/1/
> 
> 
> Testing
> -------
> 
> This does not add the `option(FOO)` yet to the configuration, not is there logic (yet)
to find the necessary libraries to enable those options. How do we want to proceed with this?
I was thinking add each `option(ENABLE_XFS)` etc. followed by a `if (ENABLE_XFS) message(FATAL_ERROR
"Please add the necessary logic to CMake to build this and see MESOS-1234."` ... but it may
honestly take just as much time to add the `find_library` logic myself...
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message