mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Re: Review Request 67707: Added a support script to check for files missing in the cmake build.
Date Tue, 26 Jun 2018 21:19:59 GMT


> On June 25, 2018, 11:15 p.m., Andrew Schwartzmeyer wrote:
> > support/check-cmake-missing-files.sh
> > Lines 23 (patched)
> > <https://reviews.apache.org/r/67707/diff/2/?file=2044476#file2044476line23>
> >
> >     Issue found in testing: this isn't compatible with Ubuntu's "sh" (which is actually
dash).

I feel while unfortunate this shouldn't be a blocker going forward; in other support scripts
we also do not guard against Ubuntu using a non POSIX `sh` implementation by default.

What do you think Andrew?


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67707/#review205323
-----------------------------------------------------------


On June 22, 2018, 11:47 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67707/
> -----------------------------------------------------------
> 
> (Updated June 22, 2018, 11:47 p.m.)
> 
> 
> Review request for mesos and Andrew Schwartzmeyer.
> 
> 
> Bugs: MESOS-8994
>     https://issues.apache.org/jira/browse/MESOS-8994
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a support script to check for files missing in the cmake build.
> 
> 
> Diffs
> -----
> 
>   support/check-cmake-missing-files.sh PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/67707/diff/2/
> 
> 
> Testing
> -------
> 
> Ran the added script and verified that the files where indeed missing from the cmake
build.
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message