mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joerg Schad <jo...@mesosphere.io>
Subject Re: Review Request 67748: Added monitoring paragraph to high-availability.md.
Date Tue, 26 Jun 2018 21:12:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67748/#review205395
-----------------------------------------------------------


Fix it, then Ship it!




Thanks Till, great addition. Only one comment regarding the exact defition of the ensemble
size metric.


docs/high-availability.md
Lines 58 (patched)
<https://reviews.apache.org/r/67748/#comment288283>

    Can we check what the exact defintion of this metric is? (connected to each other, connected
to the leader, how much does it depend on the queried master). I unfortunately do not have
the correct/best formulation here at hand, but I feel that this is a bit ambigious: 
    
    @xujyan should know more here.


- Joerg Schad


On June 26, 2018, 7:12 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67748/
> -----------------------------------------------------------
> 
> (Updated June 26, 2018, 7:12 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman and Joerg Schad.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added monitoring paragraph to high-availability.md.
> 
> 
> Diffs
> -----
> 
>   docs/high-availability.md f5d25e910763a85ddbb8c43d3dd5019c9a3b00af 
> 
> 
> Diff: https://reviews.apache.org/r/67748/diff/1/
> 
> 
> Testing
> -------
> 
> Rendered by github markdown renderer.
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message