mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Subject Re: Review Request 67730: Made Git normalize all line endings automatically.
Date Tue, 26 Jun 2018 17:49:50 GMT


> On June 25, 2018, 1:44 p.m., Mesos Reviewbot Windows wrote:
> > FAIL: Some of the unit tests failed. Please check the relevant logs.
> > 
> > Reviews applied: `['67730']`
> > 
> > Failed command: `Start-MesosCITesting`
> > 
> > All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67730
> > 
> > Relevant logs:
> > 
> > - [stout-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67730/logs/stout-tests-cmake-stdout.log):
> > 
> > ```
> >        "D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj" (default target) (10) ->
> >        (CustomBuild target) -> 
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target)
(1) ->
> >        "D:\DCOS\mesos\3rdparty\libarchive-3.3.2.vcxproj" (default target) (3) ->
> >        "D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj" (default target) (4) ->
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target)
(1) ->
> >        "D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj" (default target) (9) ->
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target)
(1) ->
> >        "D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj" (default target) (7) ->
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target)
(1) ->
> >        "D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj" (default target) (14) ->
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
> > 
> >     1 Warning(s)
> >     5 Error(s)
> > 
> > Time Elapsed 00:03:16.35
> > ```
> > 
> > - [libprocess-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67730/logs/libprocess-tests-cmake-stdout.log):
> > 
> > ```
> >        (CustomBuild target) -> 
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default
target) (1) ->
> >        "D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj" (default target) (10) ->
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default
target) (1) ->
> >        "D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj" (default target) (4) ->
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default
target) (1) ->
> >        "D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj" (default
target) (7) ->
> >        "D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj" (default target) (19) ->
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default
target) (1) ->
> >        "D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj" (default
target) (7) ->
> >        "D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj" (default target) (22) ->
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]
> > 
> >     113 Warning(s)
> >     5 Error(s)
> > 
> > Time Elapsed 00:03:35.51
> > ```
> > 
> > - [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67730/logs/mesos-tests-cmake-stdout.log):
> > 
> > ```
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
> >        "D:\DCOS\mesos\src\mesos.vcxproj" (default target) (20) ->
> >        "D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj" (default target) (30) ->
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
> >        "D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj" (default target) (8) ->
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
> >        "D:\DCOS\mesos\src\mesos.vcxproj" (default target) (20) ->
> >        "D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj" (default target) (32) ->
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
> >        "D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj" (default target)
(16) ->
> >        "D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj" (default target) (28) ->
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
> > 
> >     1 Warning(s)
> >     7 Error(s)
> > 
> > Time Elapsed 00:00:18.13
> > ```

Ah, I'm just dumb. Of course this didn't work: the CI logic is "clone repo, then apply patch
from RB, then build." This obviously doesn't work because the repo needs to be cloned with
the attributes set so that the first checkout respects the CRLF setting.


- Andrew


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67730/#review205317
-----------------------------------------------------------


On June 25, 2018, 1:21 p.m., Andrew Schwartzmeyer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67730/
> -----------------------------------------------------------
> 
> (Updated June 25, 2018, 1:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Instead of relying on the user to `core.autocrlf = true` before
> cloning, we now set this in `.gitattributes` for all files.
> 
> Only one file needed normalization via `git add --renormalize .`, it
> was `site/doap.rdf`.
> 
> The Windows instructions were updated to remove the note about setting
> autocrlf globally, and the outdated note to use Python 2 was updated
> while we were in the file.
> 
> 
> Diffs
> -----
> 
>   .gitattributes PRE-CREATION 
>   docs/windows.md 635c62c678e0a295d55aa958c75c7164c194399f 
>   site/doap.rdf ce23184de617e4f4cd82018d5847561dd84a3865 
> 
> 
> Diff: https://reviews.apache.org/r/67730/diff/2/
> 
> 
> Testing
> -------
> 
> This RR is the test since it'll trigger the currently broken review bot.
> 
> Also see https://git-scm.com/docs/gitattributes
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message