mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jie Yu <yujie....@gmail.com>
Subject Re: Review Request 67737: Updated CNI slave recovery test.
Date Tue, 26 Jun 2018 16:24:31 GMT


> On June 26, 2018, 7:44 a.m., Qian Zhang wrote:
> > Do we still need to kill the task and wait for `TASK_KILLED`?
> 
> Qian Zhang wrote:
>     And is it possible for CNI DEL command gets called after `reregisterExecutorMessage`
is received?

It's not possible. recover containerizer should happen first before executors are allowed
to re-register.


- Jie


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67737/#review205352
-----------------------------------------------------------


On June 26, 2018, 5:36 a.m., Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67737/
> -----------------------------------------------------------
> 
> (Updated June 26, 2018, 5:36 a.m.)
> 
> 
> Review request for mesos and Qian Zhang.
> 
> 
> Bugs: MESOS-9025
>     https://issues.apache.org/jira/browse/MESOS-9025
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated the test so that it can catch regression described in
> MESOS-9025. This test fails without the fix for MESOS-9025 and passes
> after the fix.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/cni_isolator_tests.cpp b58a9caca136cfa42689159389bfdcb3f92f05ee

> 
> 
> Diff: https://reviews.apache.org/r/67737/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message