mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Alexander Rojas <alexan...@mesosphere.io>
Subject Re: Review Request 67722: Fixed unproperly guarded future.
Date Tue, 26 Jun 2018 08:54:33 GMT


> On June 25, 2018, 8:14 p.m., Mesos Reviewbot Windows wrote:
> > FAIL: Some of the unit tests failed. Please check the relevant logs.
> > 
> > Reviews applied: `['67722']`
> > 
> > Failed command: `Start-MesosCITesting`
> > 
> > All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67722
> > 
> > Relevant logs:
> > 
> > - [stout-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67722/logs/stout-tests-cmake-stdout.log):
> > 
> > ```
> >        "D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj" (default target) (10) ->
> >        (CustomBuild target) -> 
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target)
(1) ->
> >        "D:\DCOS\mesos\3rdparty\libarchive-3.3.2.vcxproj" (default target) (3) ->
> >        "D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj" (default target) (4) ->
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target)
(1) ->
> >        "D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj" (default target) (9) ->
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target)
(1) ->
> >        "D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj" (default target) (7) ->
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target)
(1) ->
> >        "D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj" (default target) (14) ->
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
> > 
> >     1 Warning(s)
> >     5 Error(s)
> > 
> > Time Elapsed 00:03:15.61
> > ```
> > 
> > - [libprocess-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67722/logs/libprocess-tests-cmake-stdout.log):
> > 
> > ```
> >        (CustomBuild target) -> 
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default
target) (1) ->
> >        "D:\DCOS\mesos\3rdparty\libprocess\examples\example.vcxproj" (default target)
(8) ->
> >        "D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj" (default target) (20) ->
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default
target) (1) ->
> >        "D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj" (default target) (5) ->
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default
target) (1) ->
> >        "D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj" (default target) (7) ->
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default
target) (1) ->
> >        "D:\DCOS\mesos\3rdparty\libprocess\examples\example.vcxproj" (default target)
(8) ->
> >        "D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj" (default target) (17) ->
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
> > 
> >     113 Warning(s)
> >     5 Error(s)
> > 
> > Time Elapsed 00:03:28.21
> > ```
> > 
> > - [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67722/logs/mesos-tests-cmake-stdout.log):
> > 
> > ```
> > 
> >        "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
> >        "D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj" (default target) (4) ->
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
> >        "D:\DCOS\mesos\src\slave\mesos-agent.vcxproj" (default target) (14) ->
> >        "D:\DCOS\mesos\src\launcher\mesos-default-executor.vcxproj" (default target)
(24) ->
> >        "D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj" (default target) (32) ->
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
> >        "D:\DCOS\mesos\3rdparty\libprocess\src\process.vcxproj" (default target)
(17) ->
> >        "D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj" (default target) (23) ->
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
> > 
> > 
> >        "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
> >        "D:\DCOS\mesos\src\slave\mesos-agent.vcxproj" (default target) (14) ->
> >        "D:\DCOS\mesos\src\slave\containerizer\mesos\mesos-containerizer.vcxproj"
(default target) (20) ->
> >        "D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj" (default target) (27) ->
> >          C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]
> > 
> >     1 Warning(s)
> >     7 Error(s)
> > 
> > Time Elapsed 00:00:19.24
> > ```

It seems there was a problem downloading artifacts.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67722/#review205302
-----------------------------------------------------------


On June 25, 2018, 7:56 p.m., Alexander Rojas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67722/
> -----------------------------------------------------------
> 
> (Updated June 25, 2018, 7:56 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Greg Mann, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch fixes a bug where the code path could cause a crash because
> of calling `Fture<T>::get()` on a future which is failed.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 4ade16f044f8a4fdafd5afaba4e6a23232f83a5a 
> 
> 
> Diff: https://reviews.apache.org/r/67722/diff/1/
> 
> 
> Testing
> -------
> 
> ```sh
> make check
> ```
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message