mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Till Toenshoff <toensh...@me.com>
Subject Re: Review Request 67603: Made sure all configured shell script outputs are executable.
Date Mon, 25 Jun 2018 23:05:15 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67603/#review205328
-----------------------------------------------------------


Ship it!




Thanks for fixing those line wrappings. I once started trying to fix them everywhere but things
were not as easy as I hoped then and I got distracted. Glad to see this :)

Not yours and not part of this review - but why don't we use softlinks for these duplicated
(*agent* vs. *slave*) scripts?
Something like below should do the trick. Objections? :) - otherwise I would be willing to
contribute such change.

```
AC_CONFIG_LINKS([bin/mesos-agent.sh:bin/mesos-slave.sh])
```


configure.ac
Lines 85-86 (original), 93-95 (patched)
<https://reviews.apache.org/r/67603/#comment288250>

    I feel this is getting rather verbose given this *agent* vs. *slave* duplication.


- Till Toenshoff


On June 14, 2018, 10:13 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67603/
> -----------------------------------------------------------
> 
> (Updated June 14, 2018, 10:13 p.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Made sure all configured shell script outputs are executable.
> 
> 
> Diffs
> -----
> 
>   configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 
> 
> 
> Diff: https://reviews.apache.org/r/67603/diff/1/
> 
> 
> Testing
> -------
> 
> * `../configure`; all shell scripts created in the build tree are executable
> * `make distcheck` for good measure, but likely would not be able to detect issues here
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message