mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Schwartzmeyer <>
Subject Re: Review Request 67730: Made Git normalize all line endings automatically.
Date Mon, 25 Jun 2018 20:21:58 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated June 25, 2018, 1:21 p.m.)

Review request for mesos, Benjamin Bannier, Joseph Wu, and Till Toenshoff.


Explicitly set patch files as text.

Repository: mesos


Instead of relying on the user to `core.autocrlf = true` before
cloning, we now set this in `.gitattributes` for all files.

Only one file needed normalization via `git add --renormalize .`, it
was `site/doap.rdf`.

The Windows instructions were updated to remove the note about setting
autocrlf globally, and the outdated note to use Python 2 was updated
while we were in the file.

Diffs (updated)

  .gitattributes PRE-CREATION 
  docs/ 635c62c678e0a295d55aa958c75c7164c194399f 
  site/doap.rdf ce23184de617e4f4cd82018d5847561dd84a3865 




This RR is the test since it'll trigger the currently broken review bot.

Also see


Andrew Schwartzmeyer

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message