mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mesos Reviewbot Windows <revi...@mesos.apache.org>
Subject Re: Review Request 67728: Fixed orphan container cleanup issue in CNI isolator.
Date Mon, 25 Jun 2018 19:14:47 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67728/#review205309
-----------------------------------------------------------



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67728']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67728

Relevant logs:

- [stout-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67728/logs/stout-tests-cmake-stdout.log):

```
       "D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj" (default target) (6) ->
       (CustomBuild target) -> 
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]


       "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\3rdparty\libarchive-3.3.2.vcxproj" (default target) (3) ->
       "D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj" (default target) (4) ->
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]


       "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj" (default target) (9) ->
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]


       "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj" (default target) (10) ->
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj]


       "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj" (default target) (14) ->
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]

    1 Warning(s)
    5 Error(s)

Time Elapsed 00:03:17.53
```

- [libprocess-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67728/logs/libprocess-tests-cmake-stdout.log):

```
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]


       "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target)
(1) ->
       "D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj" (default target) (5)
->
       "D:\DCOS\mesos\3rdparty\libarchive-3.3.2.vcxproj" (default target) (13) ->
       "D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj" (default target) (16) ->
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]


       "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target)
(1) ->
       "D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj" (default target) (12) ->
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]


       "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target)
(1) ->
       "D:\DCOS\mesos\3rdparty\libprocess\examples\example.vcxproj" (default target) (9) ->
       "D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj" (default target) (19) ->
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]


       "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" (default target)
(1) ->
       "D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj" (default target) (4) ->
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj]

    113 Warning(s)
    5 Error(s)

Time Elapsed 00:03:36.63
```

- [mesos-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67728/logs/mesos-tests-cmake-stdout.log):

```

       "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\src\mesos.vcxproj" (default target) (16) ->
       "D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj" (default target) (27) ->
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\sasl2-2.1.27rc3.vcxproj]


       "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj" (default target) (4) ->
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj]


       "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\src\slave\mesos-agent.vcxproj" (default target) (12) ->
       "D:\DCOS\mesos\src\launcher\mesos-default-executor.vcxproj" (default target) (22) ->
       "D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj" (default target) (31) ->
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]


       "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
       "D:\DCOS\mesos\src\slave\mesos-agent.vcxproj" (default target) (12) ->
       "D:\DCOS\mesos\src\slave\containerizer\mesos\mesos-containerizer.vcxproj" (default
target) (19) ->
       "D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj" (default target) (25) ->
         C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
error MSB6006: "cmd.exe" exited with code 3. [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]

    1 Warning(s)
    7 Error(s)

Time Elapsed 00:00:20.40
```

- Mesos Reviewbot Windows


On June 25, 2018, noon, Jie Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67728/
> -----------------------------------------------------------
> 
> (Updated June 25, 2018, noon)
> 
> 
> Review request for mesos, Qian Zhang and Sagar Patwardhan.
> 
> 
> Bugs: MESOS-9025
>     https://issues.apache.org/jira/browse/MESOS-9025
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The bug was introduced in https://reviews.apache.org/r/65987/ when we
> want to allow nested container to have a separate network namespace than
> its parent (MESOS-8534).
> 
> The original code misses a `continue` statement after recovering regular
> containers.
> 
> I am surprised that the unit tests didn't catch the bug. We'll add a new
> unit test for catching the regression.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp b6ad4fcf9f1596c07ddeb9bbb134f4619d189671

> 
> 
> Diff: https://reviews.apache.org/r/67728/diff/1/
> 
> 
> Testing
> -------
> 
> sudo make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message