mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benjamin Bannier <benjamin.bann...@mesosphere.io>
Subject Review Request 67725: Added a principal to a disk resource's `source` field.
Date Mon, 25 Jun 2018 18:07:58 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67725/
-----------------------------------------------------------

Review request for mesos, Chun-Hung Hsiao and Jan Schlicht.


Repository: mesos


Description
-------

In this patch we store the principal given by `CreateVolume` or
`CreateDisk` operations inside the resources created by the operation.

This allows us to authorize `DestroyVolume` or `DestroyDisk`
operations against the principal which triggered the resource's
creation at some later point.


Diffs
-----

  include/mesos/mesos.proto 463e6adcdf14115b2f21270bb1fd9c45e1b67cc3 
  include/mesos/v1/mesos.proto 8eaad9c4b2a9cdd527922a004b0f7dd0dc58a7f1 
  src/resource_provider/storage/provider.cpp b90a4b81838fec410a97a10ce44a811bb81c87eb 
  src/tests/storage_local_resource_provider_tests.cpp 1afe8a8e0413ef225e952cd9cd6376e5d82774e5



Diff: https://reviews.apache.org/r/67725/diff/1/


Testing
-------

`sudo make check`


Thanks,

Benjamin Bannier


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message