mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 67526: Added container-specific cgroup FS mounts.
Date Sat, 23 Jun 2018 00:21:45 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67526/#review205256
-----------------------------------------------------------




src/launcher/executor.cpp
Lines 1281 (patched)
<https://reviews.apache.org/r/67526/#comment288182>

    Just bring this up: 
    
    why don't we just call it `container_launch_info`, or `task_launch_info`?
    
    I may prefer `task_launch_info` more, wdyt?



src/linux/fs.cpp
Lines 784 (patched)
<https://reviews.apache.org/r/67526/#comment288181>

    Could you remind me again how do we handle centos 6?



src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp
Lines 574 (patched)
<https://reviews.apache.org/r/67526/#comment288183>

    const?


- Gilbert Song


On June 19, 2018, 7:48 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67526/
> -----------------------------------------------------------
> 
> (Updated June 19, 2018, 7:48 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-8327
>     https://issues.apache.org/jira/browse/MESOS-8327
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added container-specific cgroup FS mounts.
> 
> 
> Diffs
> -----
> 
>   src/launcher/executor.cpp 541ca5b9c4bfb33a6cf341b13007ee8e881a7d89 
>   src/linux/fs.cpp 6b38b4a87984f8a62c64b74eb91c96b847b59643 
>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.hpp 81c934318dcc2bcc9df594af0ee25f0334541a65

>   src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 6d146729123b85e46f580a594fb9f9ac37b542f7

> 
> 
> Diff: https://reviews.apache.org/r/67526/diff/4/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message