mesos-reviews mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gilbert Song <songzihao1...@gmail.com>
Subject Re: Review Request 67662: Allowed mounts if the container is launched in a new mount namespace.
Date Sat, 23 Jun 2018 00:07:43 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67662/#review205255
-----------------------------------------------------------




src/slave/containerizer/mesos/launch.cpp
Lines 676-680 (original)
<https://reviews.apache.org/r/67662/#comment288180>

    I just created https://issues.apache.org/jira/browse/MESOS-9023
    
    Could we add a TODO which mention that we want to add this check back once MESOS-9023
is resolved?
    
    The reason we need this check is mount propagation, see `MountPropagation` protobuf message
in mesos.proto. Currently we do allow users to configure whether they want the mounts for
a container to propagate back to the host filesystems. We don't want to allow it for command
task.


- Gilbert Song


On June 19, 2018, 7:37 p.m., Qian Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67662/
> -----------------------------------------------------------
> 
> (Updated June 19, 2018, 7:37 p.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jason Lai.
> 
> 
> Bugs: MESOS-8327
>     https://issues.apache.org/jira/browse/MESOS-8327
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Allowed mounts if the container is launched in a new mount namespace.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/launch.cpp cec6558d0ac61bf0fec87d2e101e8f84730a765a 
> 
> 
> Diff: https://reviews.apache.org/r/67662/diff/1/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message